Skip to content
This repository was archived by the owner on Dec 22, 2021. It is now read-only.

Update i64x2.mul opcode #116

Merged
merged 2 commits into from
Oct 11, 2019
Merged

Update i64x2.mul opcode #116

merged 2 commits into from
Oct 11, 2019

Conversation

ngzhian
Copy link
Member

@ngzhian ngzhian commented Oct 4, 2019

No description provided.

@ngzhian ngzhian mentioned this pull request Oct 4, 2019
Merged
AndrewScheidecker
AndrewScheidecker approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@AndrewScheidecker AndrewScheidecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move it below i64x2.sub to keep the opcodes ordered, but otherwise LGTM.

@ngzhian
Copy link
Member Author

ngzhian commented Oct 4, 2019

Yea good suggestion, fixed!

@ngzhian ngzhian merged commit 0ff5c93 into WebAssembly:master Oct 11, 2019
@ngzhian ngzhian deleted the i64x2.mul branch October 11, 2019 20:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tlively tlively Awaiting requested review from tlively

2 more reviewers

@AndrewScheidecker AndrewScheidecker AndrewScheidecker approved these changes

@dtig dtig dtig approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ngzhian @AndrewScheidecker @dtig